-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix error showing TaskRun steps that have not run (again) #906
Conversation
This fixes an error seen when using the Tekton Dashboard with Tekton Pipelines v0.8.0. In order to support users on Tekton Pipelines v0.8.0 and earlier, the fix from tektoncd#653 is going back into the Dashboard codebase. The fix was previously reverted when Tekton Pipelines v0.9.0 fixed the root cause of the issue (https://github.com/tektoncd/dashboard/pull/795/files).
32a66d0
to
1e5cfbe
Compare
Do we still have the issue described in #782 with this workaround? |
/test tekton-dashboard-unit-tests |
/test tekton-dashboard-unit-tests |
@AlanGreene if I understand correctly, #782 was only an issue because the steps were being displayed out of order (cc @afrittoli is this correct?). A side-effect of PR #878 was that it introduced the So, I don't think that #782 is a concern any longer. However, I'm having trouble reproducing a PipelineRun with an out-of-order status. The |
@ncskier @AlanGreene good catch, I propose we do this PR into v0.4.0 and then recreate the 0.4.0 release using it, this would ensure our current master branch is still somewhat sync with Tekton Pipelines latest we can work with, which is going to be 0.9.2 atm Otherwise we're going to have this code enter master, we'll do the release pipeline and then we'd have to revert the change immediately after. Thoughts? |
I can't reproduce the ordering issue either, even without #878, tried in a clean environment with pipelines 0.8. I'm fine with adding this back to master and leaving it, showing the steps as 'not run' instead of 'failed' seems a better reflection of what actually happened. /lgtm |
Ah, hadn't appreciated that, yeah let's get it in then /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: a-roberts The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changes
This fixes an error seen when using the Tekton Dashboard with Tekton
Pipelines v0.8.0. In order to support users on Tekton Pipelines v0.8.0
and earlier, the fix from #653 is going back into the Dashboard codebase.
The fix was previously reverted when Tekton Pipelines v0.9.0 fixed the
root cause of the issue (https://github.com/tektoncd/dashboard/pull/795/files).
This issue was brought to my attention by a user running the Dashboard v0.3.0 with Tekton Pipelines v0.8.0: kabanero-io/kabanero-pipelines#86 (comment)
Note, we don't want to reintroduce issue #782 with this change.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide
for more details.