Fix error showing TaskRun steps that have not run (again)

[ncskier]

Changes

This fixes an error seen when using the Tekton Dashboard with Tekton
Pipelines v0.8.0. In order to support users on Tekton Pipelines v0.8.0
and earlier, the fix from #653 is going back into the Dashboard codebase.
The fix was previously reverted when Tekton Pipelines v0.9.0 fixed the
root cause of the issue (https://github.com/tektoncd/dashboard/pull/795/files).

This issue was brought to my attention by a user running the Dashboard v0.3.0 with Tekton Pipelines v0.8.0: kabanero-io/kabanero-pipelines#86 (comment)

Note, we don't want to reintroduce issue #782 with this change.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

• Includes tests (if functionality changed/added)
• Includes docs (if user facing)
• Commit messages follow commit message best practices

See the contribution guide
for more details.

[AlanGreene]

Do we still have the issue described in #782 with this workaround?

[ncskier]

/test tekton-dashboard-unit-tests

[ncskier]

/test tekton-dashboard-unit-tests
I'm seeing a failure with the CreatePipelineRun tests, but I haven't changed anything to do with that:
FAIL src/containers/CreatePipelineRun/CreatePipelineRun.test.js (72.894s)
https://tekton-releases.appspot.com/build/tekton-prow/pr-logs/pull/tektoncd_dashboard/906/pull-tekton-dashboard-unit-tests/1217887100729298944/

[ncskier]

@AlanGreene if I understand correctly, #782 was only an issue because the steps were being displayed out of order (cc @afrittoli is this correct?).

A side-effect of PR #878 was that it introduced the reorderSteps() function which orders steps in the UI according to the Task definition (code here).

So, I don't think that #782 is a concern any longer.

However, I'm having trouble reproducing a PipelineRun with an out-of-order status. The reorderSteps() unit tests already verify that steps get ordered according to the given Task definition. @AlanGreene, is there a place where I could put a unit test that the TaskRun view displays everything properly? I don't see any TaskRun.test.js files.

[a-roberts]

@ncskier @AlanGreene good catch, I propose we do this PR into v0.4.0 and then recreate the 0.4.0 release using it, this would ensure our current master branch is still somewhat sync with Tekton Pipelines latest we can work with, which is going to be 0.9.2 atm

Otherwise we're going to have this code enter master, we'll do the release pipeline and then we'd have to revert the change immediately after.

Thoughts?

[AlanGreene]

I can't reproduce the ordering issue either, even without #878, tried in a clean environment with pipelines 0.8. I'm fine with adding this back to master and leaving it, showing the steps as 'not run' instead of 'failed' seems a better reflection of what actually happened.

/lgtm

[a-roberts]

I can't reproduce the ordering issue either, even without #878, tried in a clean environment with pipelines 0.8. I'm fine with adding this back to master and leaving it, showing the steps as 'not run' instead of 'failed' seems a better reflection of what actually happened.

/lgtm

Ah, hadn't appreciated that, yeah let's get it in then

/approve

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a-roberts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [a-roberts]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment