Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pipeline helm chart #494

Merged
merged 1 commit into from
Apr 7, 2020
Merged

Add pipeline helm chart #494

merged 1 commit into from
Apr 7, 2020

Conversation

eddycharly
Copy link
Member

@eddycharly eddycharly commented Mar 20, 2020 •
edited
Loading

This PR proposes to add a helm chart for tekton.

This was proposed here tektoncd/plumbing#278.

The helm chart doesn't include dashboard, triggers, or operator. I will make separate charts for them in separate PRs. This one focuses only on pipeline.

The pipeline version used to create the chart is v0.11.0-rc2. Supporting v0.10 is imho not worth the effort, by the time this chart is released v0.11 will probably be out.

This is work in progress, things not implemented yet :

  • pod disruption budget (to be removed if pods don't allow more than 1 replica)
  • support admission webhooks
  • flag to enable/disable metrics
  • support for pre created service accounts in case rbac creation is disabled
  • support for customizing service type/annotations
  • flag to enable/disable pod security policy
  • helm v2/v3 support
  • update strategy configuration
  • pod security context
  • update to version v0.11.0-rc2
  • support for ingress (not relevant)
  • more crds options (useless)
  • add bash script to sync repo
  • add prow job to sync repo when pushed on master
  • improve generated doc with helm-docs
  • improve documentation
  • liveness probes (no probes available yet see Missing k8s liveness and readiness probes support pipeline#1586)
  • readiness probes (no probes available yet see Missing k8s liveness and readiness probes support pipeline#1586)
  • document a production grade configuration
  • update to v0.11.0
  • add prow presubmit to lint helm charts (Add pull-tekton-experimental-helm-lint plumbing#289)
  • add prow presubmit to check helm docs is up to date
  • create bucket and update docs
  • add prow postsubmit (on master) to sync/publish helm charts

Feedback welcome, thanks.

@tekton-robot tekton-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 20, 2020
@tekton-robot
Copy link

Hi @eddycharly. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 20, 2020
@eddycharly eddycharly mentioned this pull request Mar 20, 2020
Closed
@eddycharly eddycharly force-pushed the master branch 3 times, most recently from eeb18d1 to 24242bd Compare March 21, 2020 14:52
@tekton-robot tekton-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 21, 2020
@eddycharly eddycharly force-pushed the master branch 2 times, most recently from f0b4f01 to f1f9a0b Compare March 21, 2020 22:48
@eddycharly eddycharly mentioned this pull request Mar 21, 2020
Merged
@eddycharly eddycharly force-pushed the master branch 4 times, most recently from 14f9d9e to 4248100 Compare March 22, 2020 23:54
@tekton-robot tekton-robot added the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Mar 22, 2020
@eddycharly eddycharly force-pushed the master branch 2 times, most recently from a1feeaf to 9f821a3 Compare March 23, 2020 08:17
@tekton-robot tekton-robot removed the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Mar 23, 2020
@eddycharly
Copy link
Member Author

It should be mostly good for the technical part.
Documentation needs more work, and a few questions remain unanswered.

/cc @afrittoli @vdemeester

@eddycharly eddycharly force-pushed the master branch 5 times, most recently from 234ece2 to 6e8a9e5 Compare March 25, 2020 20:17
@eddycharly
Copy link
Member Author

@afrittoli @vdemeester this should be ready for review.

@eddycharly eddycharly force-pushed the master branch 2 times, most recently from 46c6083 to e98bbfb Compare March 30, 2020 15:33
@afrittoli
Copy link
Member

/ok-to-test

@tekton-robot tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 1, 2020
@eddycharly
Copy link
Member Author

eddycharly commented Apr 1, 2020 •
edited
Loading

@afrittoli do you have in repo config enabled on your prow instance ?
Nevermind, the answer is no ;)

@eddycharly
Copy link
Member Author

/retest

@eddycharly
Copy link
Member Author

eddycharly commented Apr 1, 2020 •
edited
Loading

I updated the chart to version v0.11.0.

Any review welcome.

Also, can someone help to set up a bucket and try to get a helm repository up and running ?

@eddycharly eddycharly mentioned this pull request Apr 2, 2020
Merged
@eddycharly
Copy link
Member Author

/retest

@eddycharly
Copy link
Member Author

/test tekton-experimental-unit-tests

@eddycharly eddycharly mentioned this pull request Apr 3, 2020
Merged
@eddycharly
Copy link
Member Author

/meow

@tekton-robot
Copy link

@eddycharly: cat image

In response to this:

/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eddycharly
Copy link
Member Author

I wonder if everyone is too busy or not interested.

I can understand both, no worries.

I will leave the PR open a couple more days and will close it by the end of the week unless someone shows some interest.

@vdemeester
Copy link
Member

/approve
/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 7, 2020
@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 7, 2020
@tekton-robot tekton-robot merged commit c01ba95 into tektoncd:master Apr 7, 2020
@eddycharly
Copy link
Member Author

Thank you @vdemeester

This was referenced Apr 7, 2020
Merged
Merged
This was referenced Apr 15, 2020
Merged
Closed
@jonashackt jonashackt mentioned this pull request Apr 7, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnuttall mnuttall Awaiting requested review from mnuttall

@vdemeester vdemeester Awaiting requested review from vdemeester

@afrittoli afrittoli Awaiting requested review from afrittoli

Assignees

@vdemeester vdemeester

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eddycharly @tekton-robot @afrittoli @vdemeester