Missing k8s liveness and readiness probes support

[ghost]

Expected Behavior

Pipeline controller and webhook containers have liveness and readiness probes (https://kubernetes.io/docs/tasks/configure-pod-container/configure-liveness-readiness-startup-probes/) defined.

Actual Behavior

Probes are missing:
https://github.com/tektoncd/pipeline/blob/v0.8.0/config/controller.yaml
https://github.com/tektoncd/pipeline/blob/v0.8.0/config/webhook.yaml

Steps to Reproduce the Problem

1. Deploy tekton v0.8.0

Additional Info

I managed to use /metrics endpoint for controller as a fix for now but webhook doesnt seem to support any GET that could be used?

[vdemeester]

/kind feature

[tekton-robot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.

/lifecycle stale

Send feedback to tektoncd/plumbing.

[tekton-robot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.

/lifecycle rotten

Send feedback to tektoncd/plumbing.

[tekton-robot]

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

Send feedback to tektoncd/plumbing.

[tekton-robot]

@tekton-robot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

Send feedback to tektoncd/plumbing.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[vdemeester]

/remove-lifecycle rotten
/remove-lifecycle stale
/reopen

[tekton-robot]

@vdemeester: Reopened this issue.

In response to this:

/remove-lifecycle rotten
/remove-lifecycle stale
/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[xiujuan95]

Could you have any plan to support liveness and readiness for tekton controller?

[ywluogg]

After a bit of research, I think adding liveness and readiness for Tekton webhook is straight forward as there is a port provided and I think can be used for readiness and liveness:

pipeline/config/webhook.yaml

Line 119 in 9b2a92c

- name: https-webhook

For the controller, we don't have a port setup yet, but I think it is necessary. Asking @bobcatfish if there is any down side for adding such port in the controller.

[ywluogg]

I'm trying to add the probes to the controller as well, but encountered port issues.

[ywluogg]

/close

[tekton-robot]

@ywluogg: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.