Fix Concurrency issue in the metrics #4222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A double locking was happening in recorder mutex which was creating unexpected behaviour. Lock needs to be done only in the function that calls opencensus stats recorder.
tekton-robot
added
the
release-note
tekton-robot
added
size/XS
|
The following is the coverage report on the affected files.
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
|
Yes, @vdemeester We probably need a e2e test or integration test to catch these type of bugs. |
e2e tests or unit tests yes 👼🏼 |
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A double locking was happening in recorder mutex which was creating
unexpected behavior. Lock needs to be done only in the function that
calls opencensus stats recorder. ReportRunningPipelineRuns and
ReportRunningTaskRuns calls RunningPipelineRuns and RunningTaskRuns
respectively which in turns lock the recorder.
Changes
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
Release Notes