-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explicitly annotate TaskRuns with release version. #4424
Conversation
Previously we were expecting TaskRuns to be decorated with an annotation specifying the release version of the tekton controller, however, the place that was populating these annotations was extremely subtle and fragile. The annotation was set as part of synthesizing the `Pod` to create where the Pod's annotations were based on the `TaskRun`'s. This contains two main changes: 1. Explicitly copy the `TaskRun`'s annotations when populating the pod's annotations to eliminate this implicit and fragile back-propagation of annotations. 2. Add an explicit decoration of the annotation, which is less fragile and executed regardless of whether the Pod is being created during this reconciliation pass. Fixes: tektoncd#4421
52c3734
to
3ccd2a9
Compare
taskRun.Annotations
before alterring them.
The following is the coverage report on the affected files.
|
/test check-pr-has-kind-label |
Hmm, looks unrelated:
/retest |
More timeouts, but in unrelated tests... /retest |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dlorenc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
Previously we were expecting TaskRuns to be decorated with an annotation specifying
the release version of the tekton controller, however, the place that was populating
these annotations was extremely subtle and fragile. The annotation was set as part
of synthesizing the
Pod
to create where the Pod's annotations were based on theTaskRun
's.This contains two main changes:
Explicitly copy the
TaskRun
's annotations when populating the pod's annotationsto eliminate this implicit and fragile back-propagation of annotations.
Add an explicit decoration of the annotation, which is less fragile and executed
regardless of whether the Pod is being created during this reconciliation pass.
Fixes: #4421
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
Release Notes