Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly annotate TaskRuns with release version. #4424

Merged
merged 1 commit into from
Dec 14, 2021

Commits on Dec 14, 2021

  1. Explicitly annotate TaskRuns with release version.

    Previously we were expecting TaskRuns to be decorated with an annotation specifying
    the release version of the tekton controller, however, the place that was populating
    these annotations was extremely subtle and fragile.  The annotation was set as part
    of synthesizing the `Pod` to create where the Pod's annotations were based on the
    `TaskRun`'s.
    
    This contains two main changes:
    1. Explicitly copy the `TaskRun`'s annotations when populating the pod's annotations
      to eliminate this implicit and fragile back-propagation of annotations.
    
    2. Add an explicit decoration of the annotation, which is less fragile and executed
      regardless of whether the Pod is being created during this reconciliation pass.
    
    Fixes: tektoncd#4421
    mattmoor committed Dec 14, 2021
    Configuration menu
    Copy the full SHA
    3ccd2a9 View commit details
    Browse the repository at this point in the history