feat(data-grid): adds presort to grid #2335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for marvelous-moxie-a6e2fe ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
amir-ba
reviewed
Aug 14, 2024
| @@ -493,6 +503,21 @@ export class DataGrid { | |||
| this.activeSortingIndex = -1; | |||
| } | |||
|
|
|||
| presortIfNeeded(): void { | |||
There was a problem hiding this comment.
Better call the fn preSort the if needed part is implied
There was a problem hiding this comment.
renamed and merged methods
tshimber
force-pushed
the
feature-data-grid-presort
branch
from
e3ad6e5
to
302559b
Compare
|
We still would need the storybook extension. |
|
a storybook example for this would be nice, and you might need to merge the main branch in the branch to fix the visual tests |
|
presort example added to doc, visual tests are fine |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2202