Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/toggle group improvements #507

Merged
merged 29 commits into from
Oct 20, 2021
Merged

Feat/toggle group improvements #507

merged 29 commits into from
Oct 20, 2021

Conversation

ChrisPaj
Copy link
Collaborator

@ChrisPaj ChrisPaj commented Aug 5, 2021

recommended changes: fix singleSelect story, add story with icons, make selected icon solid, renamings and css stuff

@ChrisPaj ChrisPaj requested a review from eeegor as a code owner August 5, 2021 12:56
@render
Copy link

render bot commented Aug 11, 2021

Copy link
Collaborator

@acstll acstll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From a code point of view, I think this is good to go. Let's wait to QA/design 🤓

@acstll acstll added the beta New beta component label Aug 12, 2021
@timheiler-ico
Copy link
Contributor

timheiler-ico commented Aug 18, 2021

Its about the stories:

– can the default border be "on" please?

– i want to see only stories for toggle group. The is only a sub component and must not be used outside the group. Will not have "usage" outside the group either.

– story naming is not aligned with properties any more (story "secondary" shows button-variant "white-background" -> story should be called "white background"... and the likes.)

– code examples contain wrong code e.g.
<scale-toggle-group variant='secondary' disabled>

– icons-story: please don't mix "before / after / only" in one story (not a good example)
please add:

  1. icon before
  2. icon only (include aria title on icon!!)
    "icon after" is not a case we'd recommend.

– not able to see the cases of e.g. xs with icons.

– story single select more prominent. (3rd place maybe?)

– add story for "Color Scheme Dark"

and little bits of design:

– design: disable border: color
Bildschirmfoto 2021-08-18 um 17 10 04

– check & adjust element roundings
Bildschirmfoto 2021-08-18 um 17 09 13

@acstll acstll mentioned this pull request Aug 27, 2021
22 tasks
@acstll acstll closed this Sep 17, 2021
@nowseemee nowseemee deleted the feat/toggle-group-improvements branch September 24, 2021 12:33
@ChrisPaj ChrisPaj restored the feat/toggle-group-improvements branch October 8, 2021 15:34
@ChrisPaj ChrisPaj reopened this Oct 11, 2021
@render
Copy link

render bot commented Oct 11, 2021

@render
Copy link

render bot commented Oct 11, 2021

@acstll acstll merged commit 0121f44 into main Oct 20, 2021
@acstll acstll deleted the feat/toggle-group-improvements branch October 20, 2021 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta New beta component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants