-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/toggle group improvements #507
Conversation
Your Render PR Server URL is https://scale-storybook-staging-pr-507.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-c49ni6pg7hpcpoptogdg. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From a code point of view, I think this is good to go. Let's wait to QA/design 🤓
Its about the stories: – can the default border be "on" please? – i want to see only stories for toggle group. The is only a sub component and must not be used outside the group. Will not have "usage" outside the group either. – story naming is not aligned with properties any more (story "secondary" shows button-variant "white-background" -> story should be called "white background"... and the likes.) – code examples contain wrong code e.g. – icons-story: please don't mix "before / after / only" in one story (not a good example)
– not able to see the cases of e.g. xs with icons. – story single select more prominent. (3rd place maybe?) – add story for "Color Scheme Dark" and little bits of design: |
Your Render PR Server URL is https://scale-storybook-staging-pr-507.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-c5i4bnrru51topq00e00. |
Your Render PR Server URL is https://scale-storybook-staging-pr-507-c3pn.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-c5i4bnrru51k3sq4nh80. |
# Conflicts: # packages/storybook-vue/stories/3_components/toggle-button/ToggleButton.stories.mdx.x
recommended changes: fix singleSelect story, add story with icons, make selected icon solid, renamings and css stuff