-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: introduce kebab events #526
Conversation
Your Render PR Server URL is https://scale-storybook-staging-pr-526.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-c4ec1441nok0bhj6lnmg. |
All frameworks in the list checked and working. Anything against this @nowseemee @oddcelot ? (Remember I only applied this to scale-checkbox to test the implementation, the rest of the components will follow…) |
very nice 🥙 |
# Conflicts: # packages/components/src/components/tag/tag.tsx
The Toggle Group is still using only camel, but we can handle that in #507 🙏 |
|
… case event names also update`@stencil/angular-output-target`
Testing a possible implementation with a utility function to transition from
scaleChange
(camel) toscale-change
(kebab).Because
scaleChange
does not work with Vue 3, and kebab-case is more "aligned" with custom elements semantics.This is a big change but we're making it non-breaking.
It will fix #490
Components affected
scaleKeyDown
, this is breaking-ish but OK)Todo list for every component emitting public events
emitEvent
utilupdate(different PR afterwards)actions
in Storybookadd new "events" section in Storybook (how?)Framework checklist
@scale-change="handleChange"
)@scale-change="handleChange"
)onScale-change={handleChange}
, …ugly but welp)(scale-change)="handleChange()"
)on:scale-change={handleChange}
)Does this mean we will change our events again to fit another framework? Nope.