You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This has been around for a while and it bothers me everytime I have to browse through the code: both StringIO and cURL objects used in the Opencast client need to be properly closed, but they are handled in an "unsafe" way (if an error occurs, neither the cURL nor the StringIO object are properly closed).
I know for a fact that older versions of Galicaster would get slower and slower (until they simply malfunctioned) when the active parameter in the [ingest] section was set to true with an incorrect or unreachable URL. I do not know if leaving these objects open when the connection fails does have any noticeable consequences in the stability of Galicaster, but it is bad programming style in any case.
The text was updated successfully, but these errors were encountered:
sinhote
pushed a commit
to sinhote/Galicaster
that referenced
this issue
Nov 21, 2017
This has been around for a while and it bothers me everytime I have to browse through the code: both StringIO and cURL objects used in the Opencast client need to be properly closed, but they are handled in an "unsafe" way (if an error occurs, neither the cURL nor the StringIO object are properly closed).
I know for a fact that older versions of Galicaster would get slower and slower (until they simply malfunctioned) when the
active
parameter in the[ingest]
section was set to true with an incorrect or unreachable URL. I do not know if leaving these objects open when the connection fails does have any noticeable consequences in the stability of Galicaster, but it is bad programming style in any case.The text was updated successfully, but these errors were encountered: