Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #562 : Properly close the cURL and StringIO objects #563

Merged
merged 1 commit into from
Jan 17, 2018

Conversation

sinhote
Copy link
Contributor

@sinhote sinhote commented Nov 21, 2017

... the title says it all :P

@rubenrua
Copy link
Contributor

Why not use a python with?

@sinhote
Copy link
Contributor Author

sinhote commented Nov 22, 2017

@rubenrua I'm way ahead of you :P (on this particular issue only!)

Neither pycurl nor StringIO are enabled to be used with with. Otherwise, I would have used it. Big fan of that construct!

@Alfro Alfro merged commit ea61a3d into teltek:2.0.x Jan 17, 2018
@Alfro
Copy link
Contributor

Alfro commented Jan 17, 2018

It looks alright. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants