Simple Order and Shipment Workflows #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robholland
requested review from
cretz,
tomwheeler and
paulnpdev
as code owners
Merged
cretz
reviewed
Mar 22, 2024
paulnpdev
reviewed
Mar 24, 2024
| @@ -0,0 +1,34 @@ | |||
| package activities | |||
There was a problem hiding this comment.
@cretz Any preferences on the question of whether notifications like these should be defined by the source (pubsub-style) or by the receiver (which I would call master/slave style, which I know is now considered very politically incorrect but I don't know any good equivalent).
I tend to prefer the latter, which would imply (here, I think) that the OP App defines the information it needs and treats other systems as auxiliary.
There was a problem hiding this comment.
Let's discuss on Slack.
paulnpdev
approved these changes
Mar 24, 2024
Co-authored-by: Paul Nordstrom <85532575+paulnpdev@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.