Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simple Order and Shipment Workflows #2
Simple Order and Shipment Workflows #2
Changes from 10 commits
cc15e9a
6d61bc9
ddc01e3
736143a
805d6a0
e620c37
e6ffd43
38203b0
f81fdbe
5d79a6c
47c74cb
9101052
b9e1f24
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cretz Any preferences on the question of whether notifications like these should be defined by the source (pubsub-style) or by the receiver (which I would call master/slave style, which I know is now considered very politically incorrect but I don't know any good equivalent).
I tend to prefer the latter, which would imply (here, I think) that the OP App defines the information it needs and treats other systems as auxiliary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's discuss on Slack.