Send original update request back in response #1480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quinn-With-Two-Ns
force-pushed
the
send-original-update-request-back
branch
from
6319ccf to
7534c3a
Compare
cretz
approved these changes
May 20, 2024
There was a problem hiding this comment.
Is there an equivalent Java and Core issue?
EDIT: I have opened temporalio/sdk-java#2073 and temporalio/sdk-core#743.
alexshtin
reviewed
May 21, 2024
internal/internal_update.go
Outdated
| @@ -157,8 +157,11 @@ func (up *updateProtocol) Accept() { | |||
| Body: protocol.MustMarshalAny(&updatepb.Acceptance{ | |||
| AcceptedRequestMessageId: up.requestMsgID, | |||
| AcceptedRequestSequencingEventId: up.requestSeqID, | |||
| AcceptedRequest: proto.Clone(&up.initialRequest).(*updatepb.Request), | |||
alexshtin
reviewed
May 21, 2024
alexshtin
approved these changes
May 21, 2024
This was referenced May 21, 2024
Server will use this value to reconstruct the update if it is lost in certain cases
Quinn-With-Two-Ns
force-pushed
the
send-original-update-request-back
branch
from
d296c79 to
4fc72a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Server will use this value to reconstruct the update if it is lost in certain cases
Undoing this PR more or less #1139