Fix bugs when using a custom FailureConverter in tests
#1490
+73
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for another contribution, could we also include some test to verify the fixes you made and make sure we don't regress in the future? |
|
Yep, sure thing! It's a long weekend here in the UK, but I'll pick it up next week 🙇🏻 |
|
Hey @Quinn-With-Two-Ns 👋🏻 I've added a test case for this now, let me know what you think! |
Quinn-With-Two-Ns
approved these changes
May 28, 2024
Follow up to temporalio#1484. 1. We weren't correctly threading the failure converter down to activities and child workflows, so they were still using the default converter. 2. The `NonRetryable` flag on the protobuf failure type wasn't being honored for custom errors.
Quinn-With-Two-Ns
force-pushed
the
failure-converter-testing
branch
from
98434dd to
5c558d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Follow up to #1484, fixing a couple of issues with using a custom failure converter:
NonRetryableflag on the protobuf failure type wasn't being honored for custom errors.Checklist
I tested this change against our app's test suite, but it could probably use a case in the SDK's test suite itself. I'd be happy to add that if you're happy with this approach generally.