Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose default sequence of payload converters for custom converter creators #139

Closed
cretz opened this issue Sep 19, 2022 · 1 comment · Fixed by #185
Closed

Expose default sequence of payload converters for custom converter creators #139

cretz opened this issue Sep 19, 2022 · 1 comment · Fixed by #185
Labels
enhancement New feature or request

Comments

@cretz
Copy link
Member

cretz commented Sep 19, 2022

Is your feature request related to a problem? Please describe.

Right now this is buried in the default constructor, but people may want this list for other reasons

Describe the solution you'd like

Make the list available

@cretz cretz added the enhancement New feature or request label Sep 19, 2022
@cretz
Copy link
Member Author

cretz commented Oct 12, 2022

Also, just make creating a data converter (and payload converter) with a different encoding payload converter prepended to the default list easier. Maybe something like temporalio.converter.default().with_encoding_payload_converter(....

cretz added a commit to cretz/temporal-sdk-python that referenced this issue Nov 2, 2022
@cretz cretz mentioned this issue Nov 3, 2022
@cretz cretz closed this as completed in #185 Nov 7, 2022
@cretz cretz closed this as completed in 929dc81 Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant