Skip to content

Commit

Permalink
Remove nexus feature flag
Browse files Browse the repository at this point in the history
  • Loading branch information
nikki-dag committed Sep 10, 2024
1 parent 89fff33 commit c5f0aad
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 17 deletions.
8 changes: 1 addition & 7 deletions app/app.go
Original file line number Diff line number Diff line change
Expand Up @@ -32,13 +32,7 @@ func NewApp(params AppParams) (*cli.App, error) {
var commands []*cli.Command

for _, command := range params.Commands {

Check failure on line 34 in app/app.go

View workflow job for this annotation

GitHub Actions / sanity checks - pull request

S1011: should replace loop with `commands = append(commands, params.Commands...)` (gosimple)
if command.Name == "nexus" {
if IsFeatureEnabled(NexusFeatureFlag) {
commands = append(commands, command)
}
} else {
commands = append(commands, command)
}
commands = append(commands, command)
}
app.Commands = commands

Expand Down
11 changes: 1 addition & 10 deletions app/feature.go
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,10 @@ import (

var (
GCPSinkFeatureFlag = "enable-gcp-sink"
NexusFeatureFlag = "enable-nexus"
featureflagFileName = "feature.json"
)

var supportFeatureFlags = []string{GCPSinkFeatureFlag, NexusFeatureFlag}
var supportFeatureFlags = []string{GCPSinkFeatureFlag}

type FeatureFlag struct {
Name string `json:"Name"`
Expand Down Expand Up @@ -133,14 +132,6 @@ func NewFeatureCommand() (CommandOut, error) {
return toggleFeature(GCPSinkFeatureFlag)
},
},
{
Name: "toggle-nexus",
Aliases: []string{"tnxs"},
Usage: "switch nexus on/off",
Action: func(c *cli.Context) error {
return toggleFeature(NexusFeatureFlag)
},
},
{
Name: "get",
Aliases: []string{"g"},
Expand Down

0 comments on commit c5f0aad

Please sign in to comment.