Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PoolBatch index, beginHeight issues and genesis logic #438

Merged
merged 13 commits into from
Aug 30, 2021

Conversation

jaybxyz
Copy link
Contributor

@jaybxyz jaybxyz commented Aug 27, 2021

Description

closes: #437

  • Remove PoolBatchIndex
  • Fix PoolBatch.Index duplicated bug
  • Fix PoolBatch.BeginHeight consistency issue on genesis init logic
  • Add simulations for genesis export, import
  • Update changelog and docs

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@jaybxyz jaybxyz self-assigned this Aug 27, 2021
@jaybxyz jaybxyz added the test and simulation test and simulation label Aug 27, 2021
@codecov
Copy link

codecov bot commented Aug 27, 2021

Codecov Report

Merging #438 (5af64ce) into develop (a42fed5) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 5af64ce differs from pull request most recent head ca1087f. Consider uploading reports for the commit ca1087f to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #438      +/-   ##
===========================================
+ Coverage    85.08%   85.10%   +0.01%     
===========================================
  Files           23       23              
  Lines         2615     2618       +3     
===========================================
+ Hits          2225     2228       +3     
  Misses         226      226              
  Partials       164      164              
Impacted Files Coverage Δ
x/liquidity/keeper/store.go 90.11% <ø> (-0.44%) ⬇️
x/liquidity/types/keys.go 100.00% <ø> (ø)
x/liquidity/keeper/batch.go 88.81% <100.00%> (ø)
x/liquidity/keeper/liquidity_pool.go 83.65% <100.00%> (ø)
x/liquidity/legacy/v043/helpers.go 100.00% <100.00%> (ø)
x/liquidity/legacy/v043/store.go 100.00% <100.00%> (ø)
x/liquidity/simulation/decoder.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a42fed5...ca1087f. Read the comment docs.

@dongsam dongsam marked this pull request as ready for review August 30, 2021 15:07
@dongsam dongsam changed the title test: patch simulation tests #437 Fix PoolBatch index, beginHeight issues and genesis logic Aug 30, 2021
@dongsam dongsam merged commit 02644bb into tendermint:develop Aug 30, 2021
jaybxyz pushed a commit to b-harvest/liquidity that referenced this pull request Sep 7, 2021
…0-candidate

Fix PoolBatch index, beginHeight issues and genesis logic tendermint#438
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test and simulation test and simulation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix simulation tests
2 participants