Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release liquidity v1.3.0 based sdk 0.43.0 #439

Merged
merged 6 commits into from
Aug 30, 2021
Merged

Release liquidity v1.3.0 based sdk 0.43.0 #439

merged 6 commits into from
Aug 30, 2021

Conversation

dongsam
Copy link
Contributor

@dongsam dongsam commented Aug 30, 2021

Description

closes: #XXXX

For #432


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

dongsam and others added 6 commits June 30, 2021 19:37
* fix: validation swap msg and offerCoinFee ceiling

* docs: update description and swagger to 2.3.1

* fix: consume all ReservedOfferCoinFee when full matched

* fix: apply suggestions of the PR

* fix: revert da7d52e pointer argument

* fix: reserveOfferCoinFee residual Issue

* fix: update comments and revert fee logic
* Porting app.go based sdk 0.43.0

* fix: sdk v0.43.0 marshaling changes

* fix: test account, mint utils

* fix: replace deprecated json cli codec

* feat: add migration codes for ReserveAccIndex

* chore: remove useless comment

* chore: refactoring test_helpers

* chore: fix lint appendAssign

* chore: refact duplicated function

* fix: WIP update docs

* docs: add changelog

* fix: refactor app.go
* test: debugging diffs of two different genesis files

* test: add more store keys in decoder

* test: fix decoder to have msg states

* fix: context block height

* test: debugging proto: wrong wireType = 0 for field Msg

* fix comment

* test: debugging

* chore: debugging pool batch decoding issue

* update: deprecate PoolBatchIndexKey and fix genesis logic

* fix: remove debugging codes and bug on integration test

* chore: reduce simulation count for timeout

* docs: update changelog

* docs: update docs based sdk 0.43.x

Co-authored-by: dongsam <dongsamb@gmail.com>
@codecov
Copy link

codecov bot commented Aug 30, 2021

Codecov Report

Merging #439 (18de54d) into master (5ffc15d) will increase coverage by 1.74%.
The diff coverage is 92.24%.

❗ Current head 18de54d differs from pull request most recent head 02644bb. Consider uploading reports for the commit 02644bb to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #439      +/-   ##
==========================================
+ Coverage   83.36%   85.10%   +1.74%     
==========================================
  Files          20       23       +3     
  Lines        2302     2618     +316     
==========================================
+ Hits         1919     2228     +309     
- Misses        218      226       +8     
+ Partials      165      164       -1     
Impacted Files Coverage Δ
x/liquidity/keeper/migration.go 50.00% <50.00%> (ø)
x/liquidity/types/swap.go 79.10% <60.00%> (+0.78%) ⬆️
x/liquidity/types/utils.go 85.41% <68.75%> (-6.90%) ⬇️
x/liquidity/keeper/batch.go 88.81% <100.00%> (+0.81%) ⬆️
x/liquidity/keeper/keeper.go 90.90% <100.00%> (+2.67%) ⬆️
x/liquidity/keeper/liquidity_pool.go 83.65% <100.00%> (+1.85%) ⬆️
x/liquidity/keeper/store.go 90.11% <100.00%> (+1.88%) ⬆️
x/liquidity/legacy/v043/helpers.go 100.00% <100.00%> (ø)
x/liquidity/legacy/v043/store.go 100.00% <100.00%> (ø)
x/liquidity/simulation/decoder.go 100.00% <100.00%> (ø)
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ffc15d...02644bb. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants