Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

program: include dynamic plugins by default #3695

Merged
merged 1 commit into from
Jun 3, 2020

Commits on Jun 2, 2020

  1. program: include dynamic plugins by default

    Summary:
    The `tensorboard.program.TensorBoard` API now includes dynamic plugins
    by default; previously, it only included static plugins. Fixes #3683.
    
    We effect this change by modifying the internal `default.get_plugins`
    method to return all the plugins to prevent this kind of confusion in
    the future.
    
    Test Plan:
    Launch TensorBoard from a small Python script:
    
    ```python
    from tensorboard import program
    import tensorboard as tb
    
    program = tb.program.TensorBoard()
    program.configure(logdir="/tmp/logs", bind_all=True)
    program.main()
    ```
    
    …and note that the projector plugin now shows up in the list of plugins,
    whereas previously it was not loaded (neither active nor inactive). Note
    that normal `tensorboard(1)` also still shows the correct plugins.
    
    wchargin-branch: program-include-dynamic-plugins
    wchargin-source: 4dbe59377617823c829a721e3c64cd8bc2dfcc90
    wchargin committed Jun 2, 2020
    Configuration menu
    Copy the full SHA
    819a6f8 View commit details
    Browse the repository at this point in the history