program: include dynamic plugins by default #3695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: The `tensorboard.program.TensorBoard` API now includes dynamic plugins by default; previously, it only included static plugins. Fixes #3683. We effect this change by modifying the internal `default.get_plugins` method to return all the plugins to prevent this kind of confusion in the future. Test Plan: Launch TensorBoard from a small Python script: ```python from tensorboard import program import tensorboard as tb program = tb.program.TensorBoard() program.configure(logdir="/tmp/logs", bind_all=True) program.main() ``` …and note that the projector plugin now shows up in the list of plugins, whereas previously it was not loaded (neither active nor inactive). Note that normal `tensorboard(1)` also still shows the correct plugins. wchargin-branch: program-include-dynamic-plugins wchargin-source: 4dbe59377617823c829a721e3c64cd8bc2dfcc90
bileschi
approved these changes
Jun 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The
tensorboard.program.TensorBoardAPI now includes dynamic pluginsby default; previously, it only included static plugins. Fixes #3683.
We effect this change by modifying the internal
default.get_pluginsmethod to return all the plugins to prevent this kind of confusion in
the future.
Test Plan:
Launch TensorBoard from a small Python script:
…and note that the projector plugin now shows up in the list of plugins,
whereas previously it was not loaded (neither active nor inactive). Note
that normal
tensorboard(1)also still shows the correct plugins.wchargin-branch: program-include-dynamic-plugins