Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

program: include dynamic plugins by default #3695

Merged
merged 1 commit into from
Jun 3, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion tensorboard/default.py
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,20 @@ class ExperimentalDebuggerV2Plugin(


def get_plugins():
"""Returns a list specifying all known TensorBoard plugins.

This includes both first-party, statically bundled plugins and
dynamic plugins.

This list can be passed to the `tensorboard.program.TensorBoard` API.

Returns:
The list of default first-party plugins.
"""
return get_static_plugins() + get_dynamic_plugins()


def get_static_plugins():
"""Returns a list specifying TensorBoard's default first-party plugins.

Plugins are specified in this list either via a TBLoader instance to load the
Expand All @@ -96,7 +110,7 @@ def get_plugins():
This list can be passed to the `tensorboard.program.TensorBoard` API.

Returns:
The list of default plugins.
The list of default first-party plugins.

:rtype: list[Type[base_plugin.TBLoader] | Type[base_plugin.TBPlugin]]
"""
Expand Down
2 changes: 1 addition & 1 deletion tensorboard/main.py
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ def run_main():
)

tensorboard = program.TensorBoard(
default.get_plugins() + default.get_dynamic_plugins(),
default.get_plugins(),
program.get_default_assets_zip_provider(),
subcommands=[uploader_subcommand.UploaderSubcommand()],
)
Expand Down