-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unblock LSC - Patch 2 - Fix initializer of instance members that reference identifiers declared in the constructor #6901
Conversation
readonly stackFramesForDisplay$; | ||
|
||
constructor(private readonly store: Store<State>) { | ||
this.codeLocationType$ = this.store.pipe( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see this one in the before snapshot. Was this change intended?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a strange case where the code is actually duplicated. I removed the other copy.
…ed in the constructor.
…ed in the constructor.
About the failures, I can see some error messages related to being "[unable to] bind to 'cardObserver' since it isn't a known property of [some components]", which (I'm speculating, because I'm not super familiar with FE/Angular) causes other That Then again... CI passed for that previous change, and I'm not sure if something in the changes on this PR make it so it only breaks with these new changes, so all of this might be a red herring (sorry if that's the case)... but just adding some thoughts here, for later. |
Riley mentioned this might be just a typing issue, but unrelated to the test breakages, which would make sense since it was not a blocker for the previous PR to be merged. |
Motivation for features / changes
There is an ongoing LSC cl/652971829 which changes how instance methods are set. The change is blocked because of our split codebase. This PR is intended as a replacement for go/tbpr/6883