Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle Inf, Nan at Kernel level for blocked ops #14077

Open
9 tasks
Tracked by #13795
VirdhatchaniKN opened this issue Oct 22, 2024 · 1 comment
Open
9 tasks
Tracked by #13795

Handle Inf, Nan at Kernel level for blocked ops #14077

VirdhatchaniKN opened this issue Oct 22, 2024 · 1 comment
Assignees
Labels

Comments

@VirdhatchaniKN
Copy link
Contributor

VirdhatchaniKN commented Oct 22, 2024

Issue :

Need to handle ops at the kernel level to Handle Nan, inf cases

Blocks the following issues :

Issues to check:

  • ttnn.sqrt - should return nan for negative values.

Issue Description :

Screenshot 2024-10-22 at 7 20 29 PM

  • But the same for nan, it gets stored in dst_reg as -inf. Need inputs on why nan is getting stored as -inf in the kernel

Screenshot 2024-10-22 at 3 28 34 PM

@VirdhatchaniKN VirdhatchaniKN added the bug Something isn't working label Oct 22, 2024
@mrakitaTT mrakitaTT added the forge label Nov 4, 2024
mouliraj-mcw added a commit that referenced this issue Dec 1, 2024
### Ticket
Link to Github Issue #5893 

### Problem description
Some TTNN operations fail with low PCC error

### What's changed

- Sqrt, Rsqrt: Modified the test file to exclude negative ranges, as
these cases will return results that are being addressed in issue
#14077.
- Sin: Adjusted the test range for bfloat8_b.

### Checklist
- [ ] All Post commit CI
@prajaramanTT
Copy link

@VirdhatchaniKN is this still an open issue ? If not, can you please close this ? Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants