-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ttnn.logaddexp and logaddexp2 fail with BFLOAT8_B operands [Bug Report][GS][WH] #6392
Comments
@npetrovic-tenstorrent @jliangTT Logically the code is working fine. Whenever one of the inputs dtype is different even for small range the PCC is very low. Also the logic of logaddexp involves three unique operations like log, add, and exp which might give only minimal drop in PCC. Also the logic of Exp has some instruction which is specific to fp16. @jliangTT I think this needs some clarification datatype handling of Bfloat8 from TT. As same kind of issue is submitted for other ops also. |
Logaddexp operations ttnn.logaddexp, ttnn.logadexp2 fail in case of BFLOAT8_B operands (at least one of the operands)
To Reproduce
Steps to reproduce the behavior:
Checkout
main
branch (soon to be merged into main) and run unit testtest_eltwise_logaddexp.py , test_eltwise_logaddexp2.py
using this command pattern:Expected behavior
There are few test cases presented in the unit test
tests/tt_eager/python_api_testing/non_working_unit_tests/grayskull/test_eltwise_logaddexp.py
and they are expected to fail with low PCC error (PCC not so low, but still not passing):The same is expected for test_eltwise_logaddexp2.py as well.
Getting Additional info for the operation under test and its behavior
To get additional information and results for different combinations of input shapes, types, layouts and memory configs for which this operation was tested you can also run locally sweep test:
To do this you should:
Getting Started
page to setup the repo, environment variables andpython-env
source build/python_env/bin/activate
python tests/tt_eager/python_api_testing/sweep_tests/run_pytorch_test.py -i tests/ttnn/python_api_testing/sweep_tests/test_configs/ci_sweep_tests_broken/grayskull/ttnn_eltwise_logaddexp_test.yaml -o ./result-sweeps
.csv
which holds all executed sweeps, among which you can also find the ones that failed and were recreated by the unit test, which you can get by searching uniquedata_seed
field.The text was updated successfully, but these errors were encountered: