Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eltwise / Reduce / Broadcast Related tasks/bugs - MCW #6445

Open
37 of 44 tasks
Tracked by #13795
umadevimcw opened this issue Mar 15, 2024 · 5 comments
Open
37 of 44 tasks
Tracked by #13795

Eltwise / Reduce / Broadcast Related tasks/bugs - MCW #6445

umadevimcw opened this issue Mar 15, 2024 · 5 comments

Comments

@umadevimcw
Copy link
Contributor

umadevimcw commented Mar 15, 2024

@umadevimcw umadevimcw changed the title Eltwise / Reduce / Broadcast Related tasks - MCW Eltwise forward/ backward / Reduce / Broadcast Related tasks - MCW Mar 15, 2024
@umadevimcw umadevimcw changed the title Eltwise forward/ backward / Reduce / Broadcast Related tasks - MCW Eltwise / Reduce / Broadcast Related tasks/bugs - MCW Mar 15, 2024
@jliangTT jliangTT removed their assignment Mar 15, 2024
@jliangTT
Copy link

i am subscribe already. thanks

@umadevimcw umadevimcw self-assigned this Mar 18, 2024
@VirdhatchaniKN
Copy link
Contributor

Regarding Issue #4384 ttl.tensor.reduce needs to be run twice to produce correct output

  • We worked on it, and found out that this is specific to dim -2 (Height).
  • Tried implementing mean in TT_DNN using reduce, sum, mean_hw , but still facing assertion issue.

Documented my work in detail : Doc Link
Conversation Link in Issue

@umadevimcw
Copy link
Contributor Author

@jliangTT @tt-aho @eyonland would like get inputs on following items

We have a few bugs that return low PCC due to input range and datatype for example

  • ops that depend on exp, will return low PCC after a certain range of inputs
  • what could be the maximum input range (low, high value in data gen) that we can use to test for such ops, and also for the data types like bfloat16 and bfloat8?

We have bugs related to storing nan and inf -> how to address those issues?
#4409 #6583 - issues were not able to store nan in WHB0

@umadevimcw
Copy link
Contributor Author

umadevimcw commented Mar 20, 2024

Regarding Issue #4384 ttl.tensor.reduce needs to be run twice to produce correct output

  • We worked on it, and found out that this is specific to dim -2 (Height).
  • Tried implementing mean in TT_DNN using reduce, sum, mean_hw , but still facing assertion issue.

Documented my work in detail : Doc Link Conversation Link in Issue

@tt-aho @eyonland @jliangTT
Also need some inputs to proceed further for reduce sum as we are getting low PCC in reduce

@VirdhatchaniKN
Copy link
Contributor

VirdhatchaniKN commented Apr 5, 2024

Hi @tt-aho , @eyonland , @jliangTT
Fix provided for three of the above listed issues

Kindly review, Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment