You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Expected behavior
There are few test cases presented in the unit test tests/tt_eager/python_api_testing/non_working_unit_tests/wormhole/test_l1_loss_sum.py and they are expected to fail with low PCC error. (close to 0.00) Eg:
Max ATOL Delta: 1908736.0, Max RTOL Delta: inf, PCC: 0.0, PCC check failed
The same is expected for test_l1_loss_mean as well.
Getting Additional info for the operation under test and its behavior
To get additional information and results for different combinations of input shapes, types, layouts and memory configs for which this operation was tested you can also run locally sweep test:
Follow the Getting Started page to setup the repo, environment variables and python-env
Activate source build/python_env/bin/activate
Run sweeps by using python tests/tt_eager/python_api_testing/sweep_tests/run_pytorch_test.py -i tests/ttnn/python_api_testing/sweep_tests/test_configs/ci_sweep_tests_broken/wormhole/ttnn_l1_loss_sum_test.yaml -o ./result-sweeps
After the run is completed all test sweeps results should be available inside specified output directory (in this case ./result-sweeps). There you will find .csv which holds all executed sweeps, among which you can also find the ones that failed and were recreated by the unit test, which you can get by searching unique data_seed field.
The text was updated successfully, but these errors were encountered:
npetrovic-tenstorrent
changed the title
ttnn.l1_loss fails with low PCC on both GS and WH #6349[Bug Report] [GS][WH]
ttnn.l1_loss fails with low PCC on both GS and WH [Bug Report] [GS][WH]
Mar 14, 2024
npetrovic-tenstorrent
changed the title
ttnn.l1_loss fails with low PCC on both GS and WH [Bug Report] [GS][WH]
ttnn.l1_loss fails with low PCC on both GS and WH [Bug Report][GS][WH]
Mar 14, 2024
l1 loss returns only a single value in torch whereas in TT single value output will be in 32x32 tensor hence while comparing the results we need to fetch the data at the 0th index
Since it involves bfloat16 computation there will be differences between the values hence compall_close is used for comparison rather than comp_pcc
ttnn.l1_loss operation fails with low PCC for reduction option cases: mean and sum. The issues occurs on both Grayskull and Wormhole devices.
To Reproduce
Steps to reproduce the behavior:
Checkout
main
branch Run unit testtest_l1_loss_sum.py
(or others) using this command pattern:Expected behavior
There are few test cases presented in the unit test
tests/tt_eager/python_api_testing/non_working_unit_tests/wormhole/test_l1_loss_sum.py
and they are expected to fail with low PCC error. (close to 0.00) Eg:The same is expected for test_l1_loss_mean as well.
Getting Additional info for the operation under test and its behavior
To get additional information and results for different combinations of input shapes, types, layouts and memory configs for which this operation was tested you can also run locally sweep test:
To do this you should:
Getting Started
page to setup the repo, environment variables andpython-env
source build/python_env/bin/activate
python tests/tt_eager/python_api_testing/sweep_tests/run_pytorch_test.py -i tests/ttnn/python_api_testing/sweep_tests/test_configs/ci_sweep_tests_broken/wormhole/ttnn_l1_loss_sum_test.yaml -o ./result-sweeps
.csv
which holds all executed sweeps, among which you can also find the ones that failed and were recreated by the unit test, which you can get by searching uniquedata_seed
field.The text was updated successfully, but these errors were encountered: