Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#6390:L1 loss pcc issue #6492

Merged
merged 1 commit into from
Mar 18, 2024
Merged

#6390:L1 loss pcc issue #6492

merged 1 commit into from
Mar 18, 2024

Conversation

umadevimcw
Copy link
Contributor

@umadevimcw umadevimcw commented Mar 18, 2024

To fix the low PCC issue

  • l1 loss returns only a single value in torch whereas in TT single value output will be in 32x32 tensor hence while comparing the results we need to fetch the data at the 0th index
  • Since it involves bfloat16 computation there will be difference between the values hence compall_close is used for comparison instead of comp_pcc

@umadevimcw umadevimcw force-pushed the umadevimcw/low_pcc_l1loss branch from 972841d to 32c03d5 Compare March 18, 2024 12:08
@umadevimcw umadevimcw merged commit 61eacf2 into main Mar 18, 2024
4 checks passed
@umadevimcw umadevimcw changed the title #6390: Update the test file and compare function #6390:L1 loss pcc issue Mar 19, 2024
@umadevimcw umadevimcw deleted the umadevimcw/low_pcc_l1loss branch March 25, 2024 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants