Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding softmax op in MLIR e2e #138

Merged
merged 1 commit into from
Jul 18, 2024
Merged

Adding softmax op in MLIR e2e #138

merged 1 commit into from
Jul 18, 2024

Conversation

sdjordjevicTT
Copy link
Contributor

@sdjordjevicTT sdjordjevicTT commented Jul 15, 2024 •
edited
Loading

  • Added e2e support for softmax op in MLIR.
  • Added simple positive and negative test cases for softmax op.

Solves: #80 and #81

@sdjordjevicTT sdjordjevicTT requested a review from nsmithtt as a code owner July 15, 2024 15:25
@sdjordjevicTT sdjordjevicTT force-pushed the sdjordjevic/adding_softmax_in_ttmlir branch from 432d84d to 55abbf6 Compare July 15, 2024 15:28
@nsmithtt nsmithtt requested a review from jnie-TT July 15, 2024 17:16
@sdjordjevicTT sdjordjevicTT force-pushed the sdjordjevic/adding_softmax_in_ttmlir branch from 55abbf6 to 3048f94 Compare July 15, 2024 20:21
nsmithtt
nsmithtt approved these changes Jul 15, 2024
View reviewed changes
Copy link
Contributor

@nsmithtt nsmithtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good thanks!

@sdjordjevicTT sdjordjevicTT force-pushed the sdjordjevic/adding_softmax_in_ttmlir branch 4 times, most recently from f6989e1 to 6023d2b Compare July 18, 2024 13:39
@sdjordjevicTT sdjordjevicTT force-pushed the sdjordjevic/adding_softmax_in_ttmlir branch from 6023d2b to c5ca525 Compare July 18, 2024 13:43
@sdjordjevicTT sdjordjevicTT force-pushed the sdjordjevic/adding_softmax_in_ttmlir branch from c5ca525 to b8a1982 Compare July 18, 2024 13:47
@sdjordjevicTT sdjordjevicTT merged commit cc7b56b into main Jul 18, 2024
4 checks passed
@sdjordjevicTT sdjordjevicTT deleted the sdjordjevic/adding_softmax_in_ttmlir branch August 12, 2024 12:13
@kmitrovicTT kmitrovicTT mentioned this pull request Dec 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nsmithtt nsmithtt nsmithtt approved these changes

@nobradovictt nobradovictt nobradovictt approved these changes

@derdeljanTT derdeljanTT Awaiting requested review from derdeljanTT

@jnie-TT jnie-TT Awaiting requested review from jnie-TT jnie-TT is a code owner

@kmabeeTT kmabeeTT Awaiting requested review from kmabeeTT kmabeeTT is a code owner

@AleksKnezevic AleksKnezevic Awaiting requested review from AleksKnezevic AleksKnezevic is a code owner

@rpavlovicTT rpavlovicTT Awaiting requested review from rpavlovicTT

@mrakitaTT mrakitaTT Awaiting requested review from mrakitaTT mrakitaTT is a code owner

@svuckovicTT svuckovicTT Awaiting requested review from svuckovicTT svuckovicTT is a code owner

@tapspatel tapspatel Awaiting requested review from tapspatel tapspatel is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sdjordjevicTT @nsmithtt @nobradovictt