Add TOSA to TTIR conversions for some simple ops #1445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgligorijevicTT
requested review from
ajakovljevicTT,
mrakitaTT and
kmitrovicTT
| module attributes {} { | ||
| func.func @test_maximum(%arg0: tensor<13x21x3xf32>, %arg1: tensor<13x21x3xf32>) -> tensor<13x21x3xf32> { | ||
| %0 = tosa.maximum %arg0, %arg1 : (tensor<13x21x3xf32>, tensor<13x21x3xf32>) -> tensor<13x21x3xf32> | ||
| // CHECK: %[[C:.*]] = tensor.empty[[C:.*]] |
There was a problem hiding this comment.
Please add more detailed tests (with detailed regexes), for some examples, take a look at test/ttmlir/Conversion/StableHLOToTTIR/exponential_minus_one_op.mlir
Similar comments for all tests, I'm leaving this on just this one for brevity.
| %0 = tosa.maximum %arg0, %arg1 : (tensor<13x21x3xf32>, tensor<13x21x3xf32>) -> tensor<13x21x3xf32> | ||
| // CHECK: %[[OP_OUT:[0-9]+]] = tensor.empty() : tensor<13x21x3xf32> | ||
| // CHECK: %{{[0-9]+}} = "ttir.maximum"(%arg{{[0-9]+}}, %arg{{[0-9]+}}, %[[OP_OUT]]){{.+}} -> tensor<13x21x3xf32> | ||
| return %0 : tensor<13x21x3xf32> |
There was a problem hiding this comment.
Add also the return check, something like:
// CHECK: return [[VAL1]] : [[TENSOR_SIZE]]
| patterns.add<TosaToTTIRDefaultDPSOpConversionPattern< | ||
| tosa::SelectOp, mlir::tt::ttir::WhereOp>>(typeConverter, ctx); | ||
| } | ||
| } // namespace |
ajakovljevicTT
approved these changes
Dec 3, 2024
|
@sgligorijevicTT please resolve conversations before merging. This way it looks like they have been ignored. Also, I think you can just say |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds TOSA to TTIR conversions for:
tosa.maximum
tosa.minimum
tosa.reciprocal
tosa.rsqrt
tosa.sigmoid
tosa.sin
tosa.select
Additionally, this adds tests for:
tosa.negate
tosa.sub
closes #1380 closes #1411 closes #1412 closes #1413 closes #1414 closes #1415 closes #1431 closes #1429 closes #1444