feat: add support for taints in MNG #1422
Conversation
Signed-off-by: Kevin Lefevre <lefevre.kevin@gmail.com>
| @@ -75,5 +75,7 @@ resource "aws_eks_node_group" "workers" { | |||
| ignore_changes = [scaling_config.0.desired_size] | |||
| } | |||
|
|
|||
| taint = lookup(each.value, "taint", null) | |||
There was a problem hiding this comment.
taint is block . So you need to loop with a dynamic block. https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/eks_node_group#taint-configuration-block
| @@ -34,7 +34,7 @@ The role ARN specified in `var.default_iam_role_arn` will be used by default. In | |||
| | key\_name | Key name for workers. Set to empty string to disable remote access | string | `var.workers_group_defaults[key_name]` | | |||
| | kubelet_extra_args | This string is passed directly to kubelet if set. Useful for adding labels or taints. Require `create_launch_template` to be `true`| string | "" | | |||
| | launch_template_id | The id of a aws_launch_template to use | string | No LT used | | |||
| | launch\_template_version | The version of the LT to use | string | none | | |||
| | launch\_template_version | The version of the LT to use | string | $Latest | | |||
There was a problem hiding this comment.
I don't think this change belongs to this PR.
| @@ -266,7 +266,7 @@ Apache 2 Licensed. See [LICENSE](https://github.com/terraform-aws-modules/terraf | |||
| | <a name="input_subnets"></a> [subnets](#input\_subnets) | A list of subnets to place the EKS cluster and workers within. | `list(string)` | n/a | yes | | |||
| | <a name="input_tags"></a> [tags](#input\_tags) | A map of tags to add to all resources. Tags added to launch configuration or templates override these values for ASG Tags only. | `map(string)` | `{}` | no | | |||
| | <a name="input_vpc_id"></a> [vpc\_id](#input\_vpc\_id) | VPC where the cluster and workers will be deployed. | `string` | n/a | yes | | |||
| | <a name="input_wait_for_cluster_timeout"></a> [wait\_for\_cluster\_timeout](#wait\_for\_cluster\_timeout) | Allows for a configurable timeout (in seconds) when waiting for a cluster to come up | `number` | `300` | no | | |||
| | <a name="input_wait_for_cluster_timeout"></a> [wait\_for\_cluster\_timeout](#input\_wait\_for\_cluster\_timeout) | A timeout (in seconds) to wait for cluster to be available. | `number` | `300` | no | | |||
There was a problem hiding this comment.
This change doesn’t belong to this PR.
| @@ -44,20 +44,21 @@ The role ARN specified in `var.default_iam_role_arn` will be used by default. In | |||
| | source\_security\_group\_ids | Source security groups for remote access to workers | list(string) | If key\_name is specified: THE REMOTE ACCESS WILL BE OPENED TO THE WORLD | | |||
| | subnets | Subnets to contain workers | list(string) | `var.workers_group_defaults[subnets]` | | |||
| | version | Kubernetes version | string | Provider default behavior | | |||
| | taint | Taints applied to node group | list | none | | |||
|
@ArchiFleKs There is a ready PR #1424 addressing MNG taint. I'm going to close this. Can you please review #1424 ? |
Sure. Done |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
PR o'clock
Description
Add support for native taints in MNG : https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/eks_node_group#taint-configuration-block
Checklist