-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for taints in MNG #1422
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -34,7 +34,7 @@ The role ARN specified in `var.default_iam_role_arn` will be used by default. In | |
| key\_name | Key name for workers. Set to empty string to disable remote access | string | `var.workers_group_defaults[key_name]` | | ||
| kubelet_extra_args | This string is passed directly to kubelet if set. Useful for adding labels or taints. Require `create_launch_template` to be `true`| string | "" | | ||
| launch_template_id | The id of a aws_launch_template to use | string | No LT used | | ||
| launch\_template_version | The version of the LT to use | string | none | | ||
| launch\_template_version | The version of the LT to use | string | $Latest | | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't think this change belongs to this PR. |
||
| max\_capacity | Max number of workers | number | `var.workers_group_defaults[asg_max_size]` | | ||
| min\_capacity | Min number of workers | number | `var.workers_group_defaults[asg_min_size]` | | ||
| name | Name of the node group. If you don't really need this, we recommend you to use `name_prefix` instead. | string | Will use the autogenerate name prefix | | ||
|
@@ -44,20 +44,21 @@ The role ARN specified in `var.default_iam_role_arn` will be used by default. In | |
| source\_security\_group\_ids | Source security groups for remote access to workers | list(string) | If key\_name is specified: THE REMOTE ACCESS WILL BE OPENED TO THE WORLD | | ||
| subnets | Subnets to contain workers | list(string) | `var.workers_group_defaults[subnets]` | | ||
| version | Kubernetes version | string | Provider default behavior | | ||
| taint | Taints applied to node group | list | none | | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. list(map) |
||
|
||
<!-- BEGINNING OF PRE-COMMIT-TERRAFORM DOCS HOOK --> | ||
## Requirements | ||
|
||
| Name | Version | | ||
|------|---------| | ||
| <a name="requirement_terraform"></a> [terraform](#requirement\_terraform) | >= 0.13.1 | | ||
| <a name="requirement_aws"></a> [aws](#requirement\_aws) | >= 3.40.0 | | ||
| <a name="requirement_aws"></a> [aws](#requirement\_aws) | >= 3.43.0 | | ||
|
||
## Providers | ||
|
||
| Name | Version | | ||
|------|---------| | ||
| <a name="provider_aws"></a> [aws](#provider\_aws) | >= 3.40.0 | | ||
| <a name="provider_aws"></a> [aws](#provider\_aws) | >= 3.43.0 | | ||
| <a name="provider_cloudinit"></a> [cloudinit](#provider\_cloudinit) | n/a | | ||
|
||
## Modules | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -75,5 +75,7 @@ resource "aws_eks_node_group" "workers" { | |
ignore_changes = [scaling_config.0.desired_size] | ||
} | ||
|
||
taint = lookup(each.value, "taint", null) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
|
||
depends_on = [var.ng_depends_on] | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,6 +2,6 @@ terraform { | |
required_version = ">= 0.13.1" | ||
|
||
required_providers { | ||
aws = ">= 3.40.0" | ||
aws = ">= 3.43.0" | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change doesn’t belong to this PR.