Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Secretsmanager secret rotation for master user password #537

Conversation

magreenbaum
Copy link
Member

@magreenbaum magreenbaum commented Jan 31, 2024

Description

Fixes #527
hashicorp/terraform-provider-aws#34180

Motivation and Context

Fixes #527

Breaking Changes

No.

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

Copy link
Member

@antonbabenko antonbabenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

modules/db_instance/main.tf Outdated Show resolved Hide resolved
Co-authored-by: Anton Babenko <anton@antonbabenko.com>
@antonbabenko antonbabenko merged commit 93c85ef into terraform-aws-modules:master Feb 2, 2024
24 checks passed
antonbabenko pushed a commit that referenced this pull request Feb 2, 2024
## [6.4.0](v6.3.1...v6.4.0) (2024-02-02)

### Features

* Secretsmanager secret rotation for master user password ([#537](#537)) ([93c85ef](93c85ef))
@antonbabenko
Copy link
Member

This PR is included in version 6.4.0 🎉

@magreenbaum magreenbaum deleted the feat/secretsmanager_secret_rotation branch February 3, 2024 00:44
Copy link

github-actions bot commented Mar 4, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Manage the rotation policy when using manage_master_user_password
2 participants