Adds support for ClassicLink DNS #121
Conversation
| enable_dns_support = "${var.default_vpc_enable_dns_support}" | ||
| enable_dns_hostnames = "${var.default_vpc_enable_dns_hostnames}" | ||
| enable_classiclink = "${var.default_vpc_enable_classiclink}" | ||
| enable_classiclink_dns_support = "${var.default_vpc_enable_classiclink_dns_support}" |
There was a problem hiding this comment.
Could you verify if this work with both old and new AWS regions? I remember there was some difference in implementations depending on a region you work with - new regions may not have classiclinks concept and it won't work.
A similar difference was between regions which didn't have concepts of IPv6 when they were created and those which has it since the very beginning.
Maybe this is working, but please double check if you can.
There was a problem hiding this comment.
Ah, I didn't realize this. It's probably not worth the effort considering how old the classiclink stuff is :)
There was a problem hiding this comment.
If this is fixed inside Terraform AWS provider then we can merge this PR. It would be great to have all features of VPC supported by this module.
Could you verify this PR by running code from examples in a couple of regions?
|
EC2 ClassicLink in 2019! 🎉 v2.14.0 has been released. |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
No description provided.