Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds support for ClassicLink DNS #121

Closed
wants to merge 1 commit into from
Closed

Adds support for ClassicLink DNS #121

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -374,9 +374,10 @@ resource "aws_vpn_gateway_route_propagation" "private" {
resource "aws_default_vpc" "this" {
count = "${var.manage_default_vpc ? 1 : 0}"

enable_dns_support = "${var.default_vpc_enable_dns_support}"
enable_dns_hostnames = "${var.default_vpc_enable_dns_hostnames}"
enable_classiclink = "${var.default_vpc_enable_classiclink}"
enable_dns_support = "${var.default_vpc_enable_dns_support}"
enable_dns_hostnames = "${var.default_vpc_enable_dns_hostnames}"
enable_classiclink = "${var.default_vpc_enable_classiclink}"
enable_classiclink_dns_support = "${var.default_vpc_enable_classiclink_dns_support}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you verify if this work with both old and new AWS regions? I remember there was some difference in implementations depending on a region you work with - new regions may not have classiclinks concept and it won't work.

A similar difference was between regions which didn't have concepts of IPv6 when they were created and those which has it since the very beginning.

Maybe this is working, but please double check if you can.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I didn't realize this. It's probably not worth the effort considering how old the classiclink stuff is :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is fixed inside Terraform AWS provider then we can merge this PR. It would be great to have all features of VPC supported by this module.

Could you verify this PR by running code from examples in a couple of regions?


tags = "${merge(var.tags, var.default_vpc_tags, map("Name", format("%s", var.default_vpc_name)))}"
}
5 changes: 5 additions & 0 deletions variables.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,6 +235,11 @@ variable "default_vpc_enable_classiclink" {
default = false
}

variable "default_vpc_enable_classiclink_dns_support" {
description = "Should be true to enable ClassicLink DNS in the Default VPC"
default = false
}

variable "default_vpc_tags" {
description = "Additional tags for the Default VPC"
default = {}
Expand Down