Add IPv6 support (Terraform 0.12 edition) #300
Conversation
Add variable "enable_ipv6" to allow enabling IPv6 support (resulting in passing "assign_generated_ipv6_cidr_block" to aws_vpc. Enabling IPv6 support further results in an Egress-only internet gateway being provisioned and routing tables of subnets being adjusted. Additional variables allow to choose the indices out of the /64 subnets based on the assigned /56 range.
This is needed exactly when var.enable_ipv6 is true.
| default = false | ||
| } | ||
|
|
||
| variable "private_subnet_ipv6_prefixes" { |
There was a problem hiding this comment.
Strictly speaking.. those are not prefixes, but more the.. indices of the prefixes? Suggestions?
There was a problem hiding this comment.
Agreed, they aren't. They are the last octet* of the given ipv6 prefix. IPv6 docs tends to be prefix based, so I chose that. Admittedly, it's not a great name, but I couldn't for the life of me figure out what a better way to describe the fact they are an enumerated list of the last octet in an IPv6 prefix such as 2001:db8::ff00:42:83XX. I explicitly didn't go with index or slice because I didn't want it to be confused as an index of another list.
So maybe ..._subnet_ipv6_octet?
(*) As a decimal because terraform didn't have functions for converting octal to dec.
There was a problem hiding this comment.
What about giving an example in the description? While it already suggests 0-256, an example like [0, 1, 2]might make it clearer. The description (and the topic) feels pretty complex :-)
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Add variable
enable_ipv6to allow enabling IPv6 support (resulting in passingassign_generated_ipv6_cidr_blocktoaws_vpc).Enabling IPv6 support further results in an egress-only internet gateway being provisioned and routing tables of subnets being adjusted.
Additional variables allow to choose the indices out of the /64 subnet based on the assigned /56 range.
This is based on @bcenker's work in #16 as well as @dekimsey's on #218, but based on a clean master branch (after the Terraform 0.12 upgrade).