Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding IPv6 assign on creation for public subnets #307

Closed
wants to merge 3 commits into from
Closed

Adding IPv6 assign on creation for public subnets #307

wants to merge 3 commits into from

Conversation

sc250024
Copy link
Contributor

@sc250024 sc250024 commented Jul 28, 2019

Allows the user to toggle automatic assignment of IPv6 addresses to public subnets.

Description

Solves issue #185. Basically, this is a mini-feature until #300 is fully approved and merged.

Currently, creation of IPv6 blocks on subnets is a manual process. This makes sure that any of those manual assignments done via the AWS console are not overridden upon running terraform apply.

Motivation and Context

Currently I have public subnets that are assigning IPv6 addresses to instances already, and would like if I could apply Terraform updates without this setting being set to false each time.

Also, I understand that #300 is also using this assign_ipv6_address_on_creation on private / database subnets as well, but as I understand it, this module creates those subnets with the intention to be private-only (i.e. IPv4). Since all IPv6 are publicly routable, I figured it made sense to only put them on public subnets in this PR.

How Has This Been Tested?

  • Ran locally against current VPC with public IPv6-enabled subnets.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@secp521
Copy link

secp521 commented Aug 23, 2019

Can we get some movement on this ?

@sc250024
Copy link
Contributor Author

@talalatpixlee I think @antonbabenko was on vacation, but he's usually quick about these things. This might not get merged because of #300 existing, but in the end, it's up to him.

@antonbabenko
Copy link
Member

As @sc250024 is saying, I am already back from vacation and doing my best to review and release new versions of terraform-aws-modules. Hopefully, I will be able to review #300 and this one during this week.

@antonbabenko antonbabenko mentioned this pull request Sep 2, 2019
@antonbabenko
Copy link
Member

v2.10.0 has been released (see #317).

@github-actions
Copy link

github-actions bot commented Nov 4, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants