Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix misspellings in comments and min_cpu_platform #1207

Merged
merged 6 commits into from
Apr 15, 2022

Conversation

sasha-s
Copy link
Contributor

@sasha-s sasha-s commented Apr 8, 2022

Fix misspellings in comments and inconsistent lookup
in node_config.min_cpu_platform.

Closes #1216

@comment-bot-dev
Copy link

comment-bot-dev commented Apr 8, 2022

Thanks for the PR! 🚀
✅ Lint checks have passed.

Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @sasha-s
Looks like this needs a rebase

Fix misspellings in comments and inconsistent lookup
in node_config.min_cpu_platform.
@sasha-s
Copy link
Contributor Author

sasha-s commented Apr 14, 2022

Rebased. Not sure if failures are related to the PR.

@bharathkkb bharathkkb merged commit 7553a2b into terraform-google-modules:master Apr 15, 2022
CPL-markus pushed a commit to WALTER-GROUP/terraform-google-kubernetes-engine that referenced this pull request Jul 15, 2024
…modules#1207)

* propagate enable_gcfs

* move changes to autogen

* Fix misspellings in comments and min_cpu_platform

Fix misspellings in comments and inconsistent lookup
in node_config.min_cpu_platform.

Co-authored-by: Bharath KKB <bharathkrishnakb@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

min_cpu_platform doesn't work on node pools
3 participants