Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration flag for enable_binary_authorization #141

Closed
bgeesaman opened this issue Apr 17, 2019 · 9 comments
Closed

Add configuration flag for enable_binary_authorization #141

bgeesaman opened this issue Apr 17, 2019 · 9 comments
Labels
enhancement New feature or request

Comments

@bgeesaman
Copy link

bgeesaman commented Apr 17, 2019

https://www.terraform.io/docs/providers/google/r/container_cluster.html#enable_binary_authorization

Suggest plumbing the flag for it with the default as false. It allows for enabling the BinAuthZ Admission controller for being able to set a whitelist policy for approved container registry paths and also enforce image signing if desired. Note that can safely be set to be true if desired as the GCP project's default BinAuthZ is allow all/permissive.

@morgante
Copy link
Contributor

+1

@aaron-lane aaron-lane added the enhancement New feature or request label May 27, 2019
aaron-lane added a commit that referenced this issue Jun 7, 2019
Add configuration flag for  #141
@morgante
Copy link
Contributor

Fixed by #160

@chrislovecnm
Copy link
Contributor

We only added this feature for private clusters. Public clusters love binary auth too.

See #186

@morgante
Copy link
Contributor

This needs to be enabled on the beta modules.

@chrislovecnm
Copy link
Contributor

it was already out in as non beta, so if we do that it will be a breaking change. So let me know if you want me to put it in as a breaking change.

@morgante
Copy link
Contributor

No, it's only on the private cluster module (which uses the beta provider). We can add it to the public beta module as well, but we don't need to add it to the main module.

@morgante morgante reopened this Jun 22, 2019
@chrislovecnm
Copy link
Contributor

I misunderstood. Terraform provider. Now the question is do we put this feature only into our beta modules, and remove it from the private template

@itlinux
Copy link

itlinux commented Jun 23, 2019 via email

@morgante
Copy link
Contributor

@itlinux I think you might be looking in the wrong place. This issue is about adding a binary_authorization flag to the module.

CPL-markus pushed a commit to WALTER-GROUP/terraform-google-kubernetes-engine that referenced this issue Jul 15, 2024
CPL-markus pushed a commit to WALTER-GROUP/terraform-google-kubernetes-engine that referenced this issue Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants