Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change to use pip3 #186

Merged
merged 1 commit into from
Jun 22, 2019

Conversation

chrislovecnm
Copy link
Contributor

This changes "pip" to "pip3" in make.sh.

On systems that have both python2 and python3 installed, we may want to use
a call to pip3 for installing modules, rather than just pip.

On my mac, it was not happy as I have both pip and pip3 installed.

This changes "pip" to "pip3" in make.sh.

On systems that have both python2 and python3 installed, we may want to use
a call to pip3 for installing modules, rather than just pip.
@chrislovecnm
Copy link
Contributor Author

chrislovecnm commented Jun 21, 2019

This seems to be causing failures with other CI runs as well https://concourse.infra.cft.tips/builds/4751

@chrislovecnm
Copy link
Contributor Author

This failed because I think this:

       1 error(s) occurred:
       
       * module.example.module.gke.google_container_cluster.zonal_primary: 1 error(s) occurred:
       
       * google_container_cluster.zonal_primary: googleapi: Error 400: Master version "1.13.6-gke.13" is unsupported., badRequest
       
       Terraform does not automatically rollback in the face of errors.
       Instead, your Terraform state file has been partially updated with
       any resources that successfully completed. Please address the error
       above and apply again to incrementally change your infrastructure.
       
       
>>>>>> ------Exception-------
>>>>>> Class: Kitchen::ActionFailed
>>>>>> Message: 1 actions failed.
>>>>>>     Converge failed on instance <node-pool-local>.  Please see .kitchen/logs/node-pool-local.log for more details
>>>>>> ----------------------
>>>>>> Please see .kitchen/logs/kitchen.log for more details
>>>>>> Also try running `kitchen diagnose --all` for configuration

@morgante morgante merged commit ba6d0b4 into terraform-google-modules:master Jun 22, 2019
@aaron-lane aaron-lane added the bug Something isn't working label Jun 24, 2019
@chrislovecnm
Copy link
Contributor Author

Actually the CI issue appears to be:

       * google_container_cluster.zonal_primary: googleapi: Error 400: Master version "1.13.6-gke.13" is unsupported., badRequest

@morgante
Copy link
Contributor

Yeah looks like we need to change our default master version.

CPL-markus pushed a commit to WALTER-GROUP/terraform-google-kubernetes-engine that referenced this pull request Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants