Creation of new variable configure_ip_masq controlling ip masq install #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrislovecnm
requested review from
aaron-lane,
adrienthebo,
Jberlinsky and
morgante
as code owners
chrislovecnm
changed the title
|
CI Error: I am making an educated guess that #186 will resolve the problem. |
|
@chrislovecnm Can you resolve conflicts? |
|
Yes I am OOO today |
chrislovecnm
force-pushed
the
ip-masq
branch
2 times, most recently
from
25def67
to
e6c33fa
Compare
chrislovecnm
changed the title
chrislovecnm
changed the title
|
I am having issues creating a cluster from the beta provider. I will post my TF later or tomorrow, if I cannot figure it out. Please do not merge |
chrislovecnm
changed the title
|
@aaron-lane @morgante the PR seems to be happy. Created a cluster off of this projects beta modules, and it worked :) . PTAL |
added 2 commits
June 26, 2019 09:56
Aliased IP addresses do not require ip masquerading anymore. There are few use cases where we would need ip masq, but usually it is not recommended to install ip masquerading. This variable allows for fine gain control on the installation of ip masq as it was always installed via the network_policy variable previously. configure_ip_masq defaults to false. Fixes: terraform-google-modules#172
Adding new field 'configure_ip_masq' to public stub domain example and removing the same field from the private cluster example. Removed the integration control to check for ip masq in the private cluster as well.
|
@morgante / @aaron-lane PTAL |
morgante
approved these changes
Jun 26, 2019
|
@morgante / @aaron-lane can we get a merge? Maintaining three open PRs is some work rebasing them all the time. The autogen is nice, but it does not merge well at all |
|
@chrislovecnm I was just waiting for tests to pass. Merged. |
Merged
CPL-markus
pushed a commit
to WALTER-GROUP/terraform-google-kubernetes-engine
that referenced
this pull request
Jul 15, 2024
…masq Creation of new variable configure_ip_masq controlling ip masq install
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aliased IP addresses do not require ip masquerading anymore. There are few use cases where we would need ip masq, but usually it is not recommended to install ip masquerading. This variable allows
for fine gain control on the installation of ip masq as it was always installed via the
network_policy variable previously.
configure_ip_masq defaults to false.
Fixes: #172
TODO:
Added a new field 'configure_ip_masq' to public stub domain example. Removed the
integration control to check for ip masq in the private cluster as well.