fix(TPGv5)!: update to TPG v5

[g-awmalik]

No description provided.

[apeabody]

This will need a manual change to update the templates, e.g. https://github.com/terraform-google-modules/terraform-google-kubernetes-engine/blob/master/autogen/main/versions.tf.tmpl#L27

[apeabody]

"container: added deletion_protection to google_container_cluster which is enabled to true by default. When enabled, this field prevents Terraform from deleting the resource. (hashicorp/terraform-provider-google#16013)"

[g-awmalik]

/gcbrun

[apeabody]

FYI @g-awmalik - This is going to need updates for the breaking change to deletion_protection.

[apeabody]

FYI @g-awmalik - This is going to need updates for the breaking change to deletion_protection.

Unfortunately deletion_protection was added new in tpg v5.0.0, so we'll need to bump the min and update all dependency modules as well. I'm working on terraform-google-network which is used several CI samples.

[apeabody]

FYI @g-awmalik - This is going to need updates for the breaking change to deletion_protection.

Unfortunately deletion_protection was added new in tpg v5.0.0, so we'll need to bump the min and update all dependency modules as well. I'm working on terraform-google-network which is used several CI samples.

Also need update to terraform-google-modules/bastion-host/google for examples/safer_cluster_iap_bastion

[apeabody]

FYI @g-awmalik - This is going to need updates for the breaking change to deletion_protection.

Unfortunately deletion_protection was added new in tpg v5.0.0, so we'll need to bump the min and update all dependency modules as well. I'm working on terraform-google-network which is used several CI samples.

Also need update to terraform-google-modules/bastion-host/google for examples/safer_cluster_iap_bastion

Need to update terraform-google-vm for terraform-google-modules/bastion-host/google

[apeabody]

Needs to be updated for tpg v5 https://github.com/terraform-google-modules/terraform-google-kubernetes-engine/blob/chore/tpg-bump/examples/safer_cluster_iap_bastion/network.tf#L50

[g-awmalik]

@apeabody - looks like this is good to go finally.

[apeabody]

@apeabody - looks like this is good to go finally.

Hi @g-awmalik - I just added some final upgrade guide entries: upgrading_to_v29.0.md. Given the volume of changes can you PTAL at the entire PR, and once the CI is green we should be ready to merge. :)

[apeabody]

LGTM!

We should get a second Review on this change.

[g-awmalik]

LGTM. Thanks for adding the upgrade docs.