Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide networking example #195

Closed
morgante opened this issue Jun 26, 2019 · 3 comments · Fixed by #288
Closed

Provide networking example #195

morgante opened this issue Jun 26, 2019 · 3 comments · Fixed by #288
Assignees
@bharathkkb
Labels
enhancement New feature or request

Comments

@morgante
Copy link
Contributor

Currently, we create networks in the test fixtures.

It would be helpful to adapt at least one of the examples themselves to include network creation (using the network module) to demonstrate how the GKE module and network module can work together.

The simple_regional example could do this.
@morgante morgante added the enhancement New feature or request label Jun 26, 2019
@morgante morgante mentioned this issue Jun 26, 2019
Closed
@aaron-lane
Copy link
Contributor

This could jive nicely with the move to ephemeral test projects.

@AtlasPilotPuppy AtlasPilotPuppy self-assigned this Aug 13, 2019
@bharathkkb
Copy link
Member

Hi @aaron-lane @morgante
Is this being worked on?

@morgante
Copy link
Contributor Author

Not currently! Feel free to pick it up.

@bharathkkb bharathkkb mentioned this issue Oct 20, 2019
Merged
aaron-lane pushed a commit that referenced this issue Nov 26, 2019
Add multiple issues to CHANGELOG
7def757 
#315, #195, #271, #339, #290, #308, #321, #261
CPL-markus pushed a commit to WALTER-GROUP/terraform-google-kubernetes-engine that referenced this issue Jul 15, 2024
Add multiple issues to CHANGELOG
a824ad5 
terraform-google-modules#315, terraform-google-modules#195, terraform-google-modules#271, terraform-google-modules#339, terraform-google-modules#290, terraform-google-modules#308, terraform-google-modules#321, terraform-google-modules#261
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bharathkkb bharathkkb

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add example for network creating and standing up GKE
4 participants
@AtlasPilotPuppy @morgante @aaron-lane @bharathkkb