Add example for network creating and standing up GKE #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bharathkkb
requested review from
aaron-lane,
adrienthebo,
Jberlinsky and
morgante
as code owners
morgante
suggested changes
Oct 21, 2019
| } | ||
|
|
||
| output "service_account" { | ||
| description = "The service account to default running nodes as if not overridden in `node_pools`." |
There was a problem hiding this comment.
Shouldn't this description simply be closer to what was actually created.
This sounds more like an input than an output as phrased.
There was a problem hiding this comment.
This description is the same in all the current examples we have. Should I just change it to service account created for the node pool?
There was a problem hiding this comment.
Got it. Do you mind updating the existing examples as well?
Suggested change
| description = "The service account to default running nodes as if not overridden in `node_pools`." | |
| description = "The default service account used for running nodes." |
morgante
suggested changes
Oct 23, 2019
| } | ||
|
|
||
| output "service_account" { | ||
| description = "The service account to default running nodes as if not overridden in `node_pools`." |
There was a problem hiding this comment.
Got it. Do you mind updating the existing examples as well?
Suggested change
| description = "The service account to default running nodes as if not overridden in `node_pools`." | |
| description = "The default service account used for running nodes." |
aaron-lane
previously requested changes
Oct 25, 2019
morgante
approved these changes
Oct 28, 2019
CPL-markus
pushed a commit
to WALTER-GROUP/terraform-google-kubernetes-engine
that referenced
this pull request
Jul 15, 2024
…re/gke-networking-ex Add example for network creating and standing up GKE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes Provide networking example #195
Added integration tests for this example
P.S: This is my first PR in CFT so if there are any nits or conventions I should be following please lmk