-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add example for network creating and standing up GKE #288
Add example for network creating and standing up GKE #288
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this!
} | ||
|
||
output "service_account" { | ||
description = "The service account to default running nodes as if not overridden in `node_pools`." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this description simply be closer to what was actually created.
This sounds more like an input than an output as phrased.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This description is the same in all the current examples we have. Should I just change it to service account created for the node pool?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it. Do you mind updating the existing examples as well?
description = "The service account to default running nodes as if not overridden in `node_pools`." | |
description = "The default service account used for running nodes." |
} | ||
|
||
output "service_account" { | ||
description = "The service account to default running nodes as if not overridden in `node_pools`." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it. Do you mind updating the existing examples as well?
description = "The service account to default running nodes as if not overridden in `node_pools`." | |
description = "The default service account used for running nodes." |
…re/gke-networking-ex Add example for network creating and standing up GKE
fixes Provide networking example #195
Added integration tests for this example
P.S: This is my first PR in CFT so if there are any nits or conventions I should be following please lmk