Add master_global_access_config

[ilkelma]

Fixes #579 and implements https://www.terraform.io/docs/providers/google/r/container_cluster.html#master_global_access_config

I ran the integration tests and got errors because the examples pin the google provider versions to ~> 3.16.0 which does not include the new master_global_access_config block.

I have a stashed commit I can push that bumps all those example versions to the latest 3.29.0 but I didn't know whether that should be part of this commit or there are other things that need to fall in line to bump all those versions.

[bharathkkb]

Thanks for the PR! I think it makes sense to follow this approach #585 (comment) to just use a boolean flag for this. Bumping dependencies as necessary also sgtm.

[ilkelma]

Thanks for the PR! I think it makes sense to follow this approach #585 (comment) to just use a boolean flag for this. Bumping dependencies as necessary also sgtm.

Done - I've bumped all versions in test files + examples - some may not be strictly necessary and I can pare back to only the ones that involve a beta private cluster (and thus would need this change) if needed.

[morgante]

@ilkelma I don't think we need to upgrade the test version—the beta examples are already in 3.29. Do you mind reverting that?

[ilkelma]

looks like the integration tests succeed if I upgrade everything but fail otherwise so something needs upgrading it would seem but i'm not sure exactly where... is it possible y'all could let me know? Likely would be faster than me trying to run the tests on my end

[morgante]

@ilkelma The error is on the simple-regional-with-networking example:

       Error: Invalid template interpolation value
       
         on ../../../cluster.tf line 261, in module "gcloud_wait_for_cluster":
        261:   create_cmd_body        = "${var.project_id} ${var.name}"
           |----------------
           | var.project_id is null
       
       The expression result is null. Cannot include a null value in a string
       template.

[ilkelma]

@ilkelma The error is on the simple-regional-with-networking example:

       Error: Invalid template interpolation value
       
         on ../../../cluster.tf line 261, in module "gcloud_wait_for_cluster":
        261:   create_cmd_body        = "${var.project_id} ${var.name}"
           |----------------
           | var.project_id is null
       
       The expression result is null. Cannot include a null value in a string
       template.

I'm not sure how this relates to my changes 🤔 i'll see if I can reproduce in local integration tests for some clues...

[morgante]

I'm not sure how this relates to my changes 🤔 i'll see if I can reproduce in local integration tests for some clues...

Yeah I'm not sure either but we can see that it's only happening on your branch. I'm especially confused why the provider version upgrade would affect it.

If you can try to troubleshoot locally, that would be helpful.

[bharathkkb]

@ilkelma @morgante its on the prepare step actually. The projects are not getting created. Seems like API activations failure. It's not related to this PR as I am seeing it in other modules as well.

Error: Error enabling the Compute Engine API required to delete the default network: Error waiting for Enable Project "ci-gke-b8681adb-e462" Services: [compute.googleapis.com]: timeout while waiting for state to become 'done: true' (last state: 'done: false', timeout: 4m0s) 

  on .terraform/modules/gke-project-2/terraform-google-project-factory-8.0.1/modules/core_project_factory/main.tf line 96, in resource "google_project" "main":
  96: resource "google_project" "main" {



Error: Error enabling the Compute Engine API required to delete the default network: Error waiting for Enable Project "ci-gke-asm-b8681adb-03ca" Services: [compute.googleapis.com]: timeout while waiting for state to become 'done: true' (last state: 'done: false', timeout: 4m0s) 

  on .terraform/modules/gke-project-asm/terraform-google-project-factory-8.0.1/modules/core_project_factory/main.tf line 96, in resource "google_project" "main":
  96: resource "google_project" "main" {

[ilkelma]

@bharathkkb @morgante I bumped the version from 3.25 -> 3.29 in the prep step (the versions.tf file in test/setup) on a hunch but i can't see the results. It got about 20 more minutes in I think so possibly got past that point?

[bharathkkb]

I think f6096e8 was flaky 1695094 has passed.

[bharathkkb]

Overall LGTM, a few suggestion 😄