-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: promote config_connector to ga #1539
feat: promote config_connector to ga #1539
Conversation
|
||
{% if autopilot_cluster != true %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Repeated condition to the preceding one here https://github.com/terraform-google-modules/terraform-google-kubernetes-engine/pull/1539/files#diff-c4d9c31e42e8a940e005adfa20b2243e0284ef6ed49b3884b0324a32770f4f6bR594 so removed
@@ -703,12 +707,6 @@ variable "kalm_config" { | |||
default = false | |||
} | |||
|
|||
variable "config_connector" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we care about minimizing the diff in the beta modules, I can move it back here and add additional if
blocks
@mnahkies |
follows on from promoting it in the provider here: GoogleCloudPlatform/magic-modules#6976
24eb22f
to
e1e56ca
Compare
Closing, looks like this change will happen in #1559 |
follows on from promoting it in the provider here:
GoogleCloudPlatform/magic-modules#6976
released in https://github.com/hashicorp/terraform-provider-google/releases/tag/v4.49.0