feat: promote config_connector to ga #1539
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnahkies
commented
Jan 21, 2023
mnahkies
commented
Jan 21, 2023
|
|
||
| {% if autopilot_cluster != true %} |
There was a problem hiding this comment.
Repeated condition to the preceding one here https://github.com/terraform-google-modules/terraform-google-kubernetes-engine/pull/1539/files#diff-c4d9c31e42e8a940e005adfa20b2243e0284ef6ed49b3884b0324a32770f4f6bR594 so removed
mnahkies
commented
Jan 21, 2023
| @@ -703,12 +707,6 @@ variable "kalm_config" { | |||
| default = false | |||
| } | |||
|
|
|||
| variable "config_connector" { | |||
There was a problem hiding this comment.
If we care about minimizing the diff in the beta modules, I can move it back here and add additional if blocks
|
@mnahkies |
follows on from promoting it in the provider here: GoogleCloudPlatform/magic-modules#6976
mnahkies
force-pushed
the
mn/chore/promote-config-connector-ga
branch
from
24eb22f
to
e1e56ca
Compare
|
Closing, looks like this change will happen in #1559 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follows on from promoting it in the provider here:
GoogleCloudPlatform/magic-modules#6976
released in https://github.com/hashicorp/terraform-provider-google/releases/tag/v4.49.0