-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #180: Add tests for beta submodules/examples #219
Fixes #180: Add tests for beta submodules/examples #219
Conversation
02b397c
to
2dd3c5c
Compare
@bohdanyurov-gl Looks like tests are failing. Can you check locally? |
@morgante we've discussed this with @aaron-lane today. Looks like there is another permission missing from ci fixtures |
Looks like there are still issues unrelated to permissions: https://concourse.infra.cft.tips/builds/6158
|
@morgante @aaron-lane has told me there was an issue with permission, here is pr: GoogleCloudPlatform/cloud-foundation-toolkit#280 Regarding the failure you've noted - it should not be related to my work. Tests pass smoothly locally |
f5898fd
to
43917d1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bohdanyurov-gl
How do you feel about fixing linters and integration tests
So it could pass the checks and be merged?
This PR blocks integration tests for #228
@bohdanyurov-gl some strange commit in PR, probably result of incorrect rebase/merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove needless merge commit
@kopachevsky I haven't added it. Waiting for @morgante's response |
Linters and integration tests are not related to my work. Please wait for other PRs to be merged: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rebase on master
and add the new tests in the Cloud Build yaml.
aa32a5a
to
cd4c063
Compare
836c69b
to
c5d1e0a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test fixtures should not directly invoke or create resources (as the other fixtures show).
Instead, your new fixture should merely wrap the existing beta cluster example: https://github.com/terraform-google-modules/terraform-google-kubernetes-engine/tree/master/examples/simple_regional_beta
60ca457
to
779ed8a
Compare
…mples terraform-google-modules#180 Added tests for the beta private cluster.
779ed8a
to
d1098b5
Compare
The example has been wrapped. Additional fixture resources can be moved to the example subsequently.
…ix/180 Fixes terraform-google-modules#180: Add tests for beta submodules/examples
Fixes #180
Fixes #185
Tests for beta GKE features.