Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

node_pool_labels, node_pool_tags, and node_pool_taints are optional #269

Closed
wants to merge 4 commits into from
Closed

node_pool_labels, node_pool_tags, and node_pool_taints are optional #269

wants to merge 4 commits into from

Conversation

evkuzin
Copy link

@evkuzin evkuzin commented Sep 25, 2019 •
edited by morgante

Fixes #3

@aaron-lane aaron-lane added the enhancement New feature or request label Sep 25, 2019
@naseemkullah naseemkullah mentioned this pull request Oct 28, 2019
Closed
@morgante
Copy link
Contributor

@cray0000 Can you pick this up? It's not passing tests.

@cray0000
Copy link
Contributor

@morgante sure!

@cray0000 cray0000 self-assigned this Oct 31, 2019
@cray0000
Copy link
Contributor

Closing in favor of #318

@cray0000 cray0000 closed this Nov 13, 2019
@cray0000 cray0000 mentioned this pull request Nov 13, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morgante morgante morgante approved these changes

@aaron-lane aaron-lane Awaiting requested review from aaron-lane

@adrienthebo adrienthebo Awaiting requested review from adrienthebo

@Jberlinsky Jberlinsky Awaiting requested review from Jberlinsky

Assignees

@cray0000 cray0000

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make node_pool_labels, node_pool_tags, and node_pool_taints all optional
4 participants
@evkuzin @morgante @cray0000 @aaron-lane