Make node_pools_* params optional and allow pool-specific overrides. #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cray0000
requested review from
aaron-lane,
adrienthebo,
Jberlinsky and
morgante
as code owners
|
The decision to make setting the defaults values a separate logical step was made instead of the implementation seen in #269 because that implementation was leading to multiple hardcoded patches in the code logic. |
aaron-lane
suggested changes
Nov 15, 2019
Makefile
Outdated
| @@ -18,7 +18,7 @@ | |||
| # Make will use bash instead of sh | |||
| SHELL := /usr/bin/env bash | |||
|
|
|||
| DOCKER_TAG_VERSION_DEVELOPER_TOOLS := 0.4.6 | |||
| DOCKER_TAG_VERSION_DEVELOPER_TOOLS := 0.5.4 | |||
There was a problem hiding this comment.
Suggested change
| DOCKER_TAG_VERSION_DEVELOPER_TOOLS := 0.5.4 | |
| DOCKER_TAG_VERSION_DEVELOPER_TOOLS := 0 |
|
I may have messed up the merge commit based on the lint result. 😊 |
aaron-lane
previously approved these changes
Nov 20, 2019
There was a problem hiding this comment.
@cray0000 please rebase against master and we can merge this!
cray0000
force-pushed
the
f-make-params-optional
branch
2 times, most recently
from
56e15c5
to
0eb1e16
Compare
[test/deploy_service] Add retry logic to wait until the nginx service becomes reachable [build] Add 120 seconds delay after the 'prepare' step
cray0000
force-pushed
the
f-make-params-optional
branch
from
1a1d449
to
bf48602
Compare
|
@aaron-lane In the last run |
aaron-lane
approved these changes
Nov 21, 2019
CPL-markus
pushed a commit
to WALTER-GROUP/terraform-google-kubernetes-engine
that referenced
this pull request
Jul 15, 2024
…params-optional Make node_pools_* params optional and allow pool-specific overrides.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main idea of the PR is to move setting the dynamic default values for
node_pools_*options into a separate step:node_pools_labelsnode_pools_metadatanode_pools_taintsnode_pools_tagsnode_pools_oauth_scopesTherefore I added a new file
autogen/variables_defaults.tfthe purpose of which is to setup the dynamic defaults for variables and shadow them with the locals of the same name.I've also changed the example/test case
node_pools-- it selectively setsnode_pools_*options only for some pools. Also note the complete absense of thenode_pools_oauth_scopesoption in the example.