-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make node_pools_* params optional and allow pool-specific overrides. #318
Make node_pools_* params optional and allow pool-specific overrides. #318
Conversation
The decision to make setting the defaults values a separate logical step was made instead of the implementation seen in #269 because that implementation was leading to multiple hardcoded patches in the code logic. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @cray0000!
Makefile
Outdated
@@ -18,7 +18,7 @@ | |||
# Make will use bash instead of sh | |||
SHELL := /usr/bin/env bash | |||
|
|||
DOCKER_TAG_VERSION_DEVELOPER_TOOLS := 0.4.6 | |||
DOCKER_TAG_VERSION_DEVELOPER_TOOLS := 0.5.4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DOCKER_TAG_VERSION_DEVELOPER_TOOLS := 0.5.4 | |
DOCKER_TAG_VERSION_DEVELOPER_TOOLS := 0 |
I may have messed up the merge commit based on the lint result. 😊 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cray0000 please rebase against master and we can merge this!
56e15c5
to
0eb1e16
Compare
[test/deploy_service] Add retry logic to wait until the nginx service becomes reachable [build] Add 120 seconds delay after the 'prepare' step
1a1d449
to
bf48602
Compare
@aaron-lane In the last run |
…params-optional Make node_pools_* params optional and allow pool-specific overrides.
The main idea of the PR is to move setting the dynamic default values for
node_pools_*
options into a separate step:node_pools_labels
node_pools_metadata
node_pools_taints
node_pools_tags
node_pools_oauth_scopes
Therefore I added a new file
autogen/variables_defaults.tf
the purpose of which is to setup the dynamic defaults for variables and shadow them with the locals of the same name.I've also changed the example/test case
node_pools
-- it selectively setsnode_pools_*
options only for some pools. Also note the complete absense of thenode_pools_oauth_scopes
option in the example.