Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ASM module #538

Merged
merged 10 commits into from
Jun 23, 2020
Merged

Add ASM module #538

merged 10 commits into from
Jun 23, 2020

Conversation

bharathkkb
Copy link
Member

@bharathkkb bharathkkb commented May 23, 2020 •
edited

  • Adds ASM module
    • Downloads and installs ASM
    • Produces ASM resource patch yamls
    • Optionally enables registration to GKE Hub
  • Adds example with ASM module
  • Adds tests for ASM module

TODO:

@bharathkkb bharathkkb requested review from Jberlinsky and a team as code owners May 23, 2020 04:14
@bharathkkb bharathkkb marked this pull request as draft May 23, 2020 04:14
@bharathkkb bharathkkb mentioned this pull request May 27, 2020
Merged
@bharathkkb bharathkkb marked this pull request as ready for review May 27, 2020 15:05
@bharathkkb bharathkkb changed the title [DRAFT] Add ASM module Add ASM module May 27, 2020
@morgante
Copy link
Contributor

@bharathkkb Can you resole conflicts? Is this ready for final review?

@bharathkkb
Copy link
Member Author

@morgante it's ready for review. Will resolve the conflicts.
CI is failing for on CloudBuild, I think anthoscli for some reason is not picking up ADC. Same integration test is working locally.

@bharathkkb
wip asm module
430de9c 
add gke hub registration

asm patch changes

add binary checks, add tests

fmt

lint

add readme

default gcloud module to ADC, expose via var
@bharathkkb bharathkkb mentioned this pull request Jun 23, 2020
Merged
@morgante morgante merged commit 6ff27f9 into master Jun 23, 2020
@morgante morgante deleted the add-asm-module branch July 7, 2020 17:20
CPL-markus pushed a commit to WALTER-GROUP/terraform-google-kubernetes-engine that referenced this pull request Jul 15, 2024
@bharathkkb
feat: Add ASM install submodule (terraform-google-modules#538)
9d6d01f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erichaase erichaase erichaase left review comments

@morgante morgante morgante approved these changes

@Jberlinsky Jberlinsky Awaiting requested review from Jberlinsky

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bharathkkb @morgante @erichaase